about summary refs log tree commit diff
path: root/src/settings/plugins/ifupdown/nms-ifupdown-connection.c
diff options
context:
space:
mode:
Diffstat (limited to 'src/settings/plugins/ifupdown/nms-ifupdown-connection.c')
-rw-r--r--src/settings/plugins/ifupdown/nms-ifupdown-connection.c33
1 files changed, 11 insertions, 22 deletions
diff --git a/src/settings/plugins/ifupdown/nms-ifupdown-connection.c b/src/settings/plugins/ifupdown/nms-ifupdown-connection.c
index 1b817044..c3d231fe 100644
--- a/src/settings/plugins/ifupdown/nms-ifupdown-connection.c
+++ b/src/settings/plugins/ifupdown/nms-ifupdown-connection.c
@@ -49,20 +49,10 @@ G_DEFINE_TYPE (NMIfupdownConnection, nm_ifupdown_connection, NM_TYPE_SETTINGS_CO
 
 /*****************************************************************************/
 
-#define _NMLOG_PREFIX_NAME      "ifupdown"
-#define _NMLOG_DOMAIN           LOGD_SETTINGS
-#define _NMLOG(level, ...) \
-    nm_log ((level), _NMLOG_DOMAIN, NULL, NULL, \
-            "%s" _NM_UTILS_MACRO_FIRST (__VA_ARGS__), \
-            _NMLOG_PREFIX_NAME": " \
-            _NM_UTILS_MACRO_REST (__VA_ARGS__))
-
-/*****************************************************************************/
-
 static gboolean
 supports_secrets (NMSettingsConnection *connection, const char *setting_name)
 {
-	_LOGI ("supports_secrets() for setting_name: '%s'", setting_name);
+	nm_log_info (LOGD_SETTINGS, "supports_secrets() for setting_name: '%s'", setting_name);
 
 	return (strcmp (setting_name, NM_SETTING_WIRELESS_SECURITY_SETTING_NAME) == 0);
 }
@@ -74,27 +64,26 @@ nm_ifupdown_connection_init (NMIfupdownConnection *connection)
 {
 }
 
-NMIfupdownConnection *
+NMIfupdownConnection*
 nm_ifupdown_connection_new (if_block *block)
 {
-	NMIfupdownConnection *connection;
+	GObject *object;
 	GError *error = NULL;
 
 	g_return_val_if_fail (block != NULL, NULL);
 
-	connection = g_object_new (NM_TYPE_IFUPDOWN_CONNECTION, NULL);
+	object = g_object_new (NM_TYPE_IFUPDOWN_CONNECTION, NULL);
 
-	/* FIXME(copy-on-write-connection): avoid modifying NMConnection instances and share them via copy-on-write. */
-	if (!ifupdown_update_connection_from_if_block (nm_settings_connection_get_connection (NM_SETTINGS_CONNECTION (connection)),
-	                                               block,
-	                                               &error)) {
-		_LOGW ("invalid connection read from /etc/network/interfaces: %s",
-		       error->message);
-		g_object_unref (connection);
+	if (!ifupdown_update_connection_from_if_block (NM_CONNECTION (object), block, &error)) {
+		nm_log_warn (LOGD_SETTINGS, "%s.%d - invalid connection read from /etc/network/interfaces: %s",
+		             __FILE__,
+		             __LINE__,
+		             error->message);
+		g_object_unref (object);
 		return NULL;
 	}
 
-	return connection;
+	return (NMIfupdownConnection *) object;
 }
 
 static void