about summary refs log tree commit diff
path: root/src/core/settings/nm-settings-connection.c
diff options
context:
space:
mode:
Diffstat (limited to 'src/core/settings/nm-settings-connection.c')
-rw-r--r--src/core/settings/nm-settings-connection.c392
1 files changed, 196 insertions, 196 deletions
diff --git a/src/core/settings/nm-settings-connection.c b/src/core/settings/nm-settings-connection.c
index 71da97d0..55efaebe 100644
--- a/src/core/settings/nm-settings-connection.c
+++ b/src/core/settings/nm-settings-connection.c
@@ -135,7 +135,7 @@ typedef struct _NMSettingsConnectionPrivate {
 
     struct {
         NMConnectionSerializationOptions options;
-        GVariant *                       variant;
+        GVariant                        *variant;
     } getsettings_cached;
 
     NMSettingsStorage *storage;
@@ -223,7 +223,7 @@ static const NMDBusInterfaceInfoExtended interface_info_settings_connection;
 
 static void  update_agent_secrets_cache(NMSettingsConnection *self, NMConnection *new);
 static guint _get_seen_bssids(NMSettingsConnection *self,
-                              const char *          strv_buf[static(SEEN_BSSIDS_MAX + 1)]);
+                              const char           *strv_buf[static(SEEN_BSSIDS_MAX + 1)]);
 
 /*****************************************************************************/
 
@@ -264,7 +264,7 @@ void
 _nm_settings_connection_set_storage(NMSettingsConnection *self, NMSettingsStorage *storage)
 {
     NMSettingsConnectionPrivate *priv = NM_SETTINGS_CONNECTION_GET_PRIVATE(self);
-    const char *                 filename;
+    const char                  *filename;
 
     nm_assert(NM_IS_SETTINGS_STORAGE(storage));
     nm_assert(!priv->storage
@@ -316,7 +316,7 @@ static GVariant *
 _getsettings_cached_get(NMSettingsConnection *self, const NMConnectionSerializationOptions *options)
 {
     NMSettingsConnectionPrivate *priv = NM_SETTINGS_CONNECTION_GET_PRIVATE(self);
-    GVariant *                   variant;
+    GVariant                    *variant;
 
     if (priv->getsettings_cached.variant) {
         if (nm_connection_serialization_options_equal(&priv->getsettings_cached.options, options)) {
@@ -362,12 +362,12 @@ nm_settings_connection_get_connection(NMSettingsConnection *self)
 }
 
 void
-_nm_settings_connection_set_connection(NMSettingsConnection *           self,
-                                       NMConnection *                   new_connection,
-                                       NMConnection **                  out_connection_old,
+_nm_settings_connection_set_connection(NMSettingsConnection            *self,
+                                       NMConnection                    *new_connection,
+                                       NMConnection                   **out_connection_old,
                                        NMSettingsConnectionUpdateReason update_reason)
 {
-    NMSettingsConnectionPrivate *priv            = NM_SETTINGS_CONNECTION_GET_PRIVATE(self);
+    NMSettingsConnectionPrivate  *priv           = NM_SETTINGS_CONNECTION_GET_PRIVATE(self);
     gs_unref_object NMConnection *connection_old = NULL;
 
     nm_assert(NM_IS_CONNECTION(new_connection));
@@ -408,7 +408,7 @@ _nm_settings_connection_set_connection(NMSettingsConnection *           self,
 
 gboolean
 nm_settings_connection_has_unmodified_applied_connection(NMSettingsConnection *self,
-                                                         NMConnection *        applied_connection,
+                                                         NMConnection         *applied_connection,
                                                          NMSettingCompareFlags compare_flags)
 {
     g_return_val_if_fail(NM_IS_SETTINGS_CONNECTION(self), FALSE);
@@ -437,7 +437,7 @@ nm_settings_connection_get_last_secret_agent_version_id(NMSettingsConnection *se
 
 gboolean
 nm_settings_connection_check_visibility(NMSettingsConnection *self,
-                                        NMSessionMonitor *    session_monitor)
+                                        NMSessionMonitor     *session_monitor)
 {
     NMSettingConnection *s_con;
     guint32              num, i;
@@ -483,9 +483,9 @@ gboolean
 nm_settings_connection_check_permission(NMSettingsConnection *self, const char *permission)
 {
     NMSettingsConnectionPrivate *priv;
-    NMSettingConnection *        s_con;
+    NMSettingConnection         *s_con;
     guint32                      num, i;
-    const char *                 puser;
+    const char                  *puser;
 
     g_return_val_if_fail(NM_IS_SETTINGS_CONNECTION(self), FALSE);
 
@@ -531,8 +531,8 @@ nm_settings_connection_check_permission(NMSettingsConnection *self, const char *
 static void
 update_agent_secrets_cache(NMSettingsConnection *self, NMConnection *new)
 {
-    NMSettingsConnectionPrivate *priv      = NM_SETTINGS_CONNECTION_GET_PRIVATE(self);
-    gs_unref_variant GVariant *old_secrets = NULL;
+    NMSettingsConnectionPrivate *priv        = NM_SETTINGS_CONNECTION_GET_PRIVATE(self);
+    gs_unref_variant GVariant   *old_secrets = NULL;
 
     old_secrets = g_steal_pointer(&priv->agent_secrets);
 
@@ -552,11 +552,11 @@ update_agent_secrets_cache(NMSettingsConnection *self, NMConnection *new)
 }
 
 static gboolean
-_secrets_update(NMConnection * connection,
-                const char *   setting_name,
-                GVariant *     secrets,
+_secrets_update(NMConnection  *connection,
+                const char    *setting_name,
+                GVariant      *secrets,
                 NMConnection **out_new_connection,
-                GError **      error)
+                GError       **error)
 {
     gs_unref_variant GVariant *secrets_setting = NULL;
 
@@ -605,14 +605,14 @@ _secrets_update(NMConnection * connection,
 }
 
 gboolean
-nm_settings_connection_update(NMSettingsConnection *           self,
-                              NMConnection *                   new_connection,
+nm_settings_connection_update(NMSettingsConnection            *self,
+                              NMConnection                    *new_connection,
                               NMSettingsConnectionPersistMode  persist_mode,
                               NMSettingsConnectionIntFlags     sett_flags,
                               NMSettingsConnectionIntFlags     sett_mask,
                               NMSettingsConnectionUpdateReason update_reason,
-                              const char *                     log_context_name,
-                              GError **                        error)
+                              const char                      *log_context_name,
+                              GError                         **error)
 {
     g_return_val_if_fail(NM_IS_SETTINGS_CONNECTION(self), FALSE);
 
@@ -645,10 +645,10 @@ typedef enum {
 } CallIdType;
 
 struct _NMSettingsConnectionCallId {
-    NMSettingsConnection *          self;
+    NMSettingsConnection           *self;
     CList                           call_ids_lst;
     gboolean                        had_applied_connection;
-    NMConnection *                  applied_connection;
+    NMConnection                   *applied_connection;
     NMSettingsConnectionSecretsFunc callback;
     gpointer                        callback_data;
 
@@ -666,9 +666,9 @@ struct _NMSettingsConnectionCallId {
 
 static void
 _get_secrets_info_callback(NMSettingsConnectionCallId *call_id,
-                           const char *                agent_username,
-                           const char *                setting_name,
-                           GError *                    error)
+                           const char                 *agent_username,
+                           const char                 *setting_name,
+                           GError                     *error)
 {
     if (call_id->callback) {
         call_id->callback(call_id->self,
@@ -731,16 +731,16 @@ secret_is_system_owned(NMSettingSecretFlags flags, gpointer user_data)
 }
 
 static void
-get_cmp_flags(NMSettingsConnection *       self,    /* only needed for logging */
-              NMSettingsConnectionCallId * call_id, /* only needed for logging */
-              NMConnection *               connection,
-              const char *                 agent_dbus_owner,
+get_cmp_flags(NMSettingsConnection        *self,    /* only needed for logging */
+              NMSettingsConnectionCallId  *call_id, /* only needed for logging */
+              NMConnection                *connection,
+              const char                  *agent_dbus_owner,
               gboolean                     agent_has_modify,
-              const char *                 setting_name, /* only needed for logging */
+              const char                  *setting_name, /* only needed for logging */
               NMSecretAgentGetSecretsFlags flags,
-              GVariant *                   secrets,
-              gboolean *                   agent_had_system,
-              ForEachSecretFlags *         cmp_flags)
+              GVariant                    *secrets,
+              gboolean                    *agent_had_system,
+              ForEachSecretFlags          *cmp_flags)
 {
     gboolean is_self = (nm_settings_connection_get_connection(self) == connection);
 
@@ -810,13 +810,13 @@ get_cmp_flags(NMSettingsConnection *       self,    /* only needed for logging *
 
 gboolean
 nm_settings_connection_new_secrets(NMSettingsConnection *self,
-                                   NMConnection *        applied_connection,
-                                   const char *          setting_name,
-                                   GVariant *            secrets,
-                                   GError **             error)
+                                   NMConnection         *applied_connection,
+                                   const char           *setting_name,
+                                   GVariant             *secrets,
+                                   GError              **error)
 {
     gs_unref_object NMConnection *new_connection = NULL;
-    NMConnection *                connection;
+    NMConnection                 *connection;
 
     if (!nm_settings_connection_has_unmodified_applied_connection(self,
                                                                   applied_connection,
@@ -849,8 +849,8 @@ nm_settings_connection_new_secrets(NMSettingsConnection *self,
 }
 
 static gboolean
-match_secret_by_setting_name_and_flags_cb(NMSetting *          setting,
-                                          const char *         secret,
+match_secret_by_setting_name_and_flags_cb(NMSetting           *setting,
+                                          const char          *secret,
                                           NMSettingSecretFlags flags,
                                           gpointer             user_data)
 {
@@ -861,22 +861,22 @@ match_secret_by_setting_name_and_flags_cb(NMSetting *          setting,
 }
 
 static void
-get_secrets_done_cb(NMAgentManager *             manager,
+get_secrets_done_cb(NMAgentManager              *manager,
                     NMAgentManagerCallId         call_id_a,
-                    const char *                 agent_dbus_owner,
-                    const char *                 agent_username,
+                    const char                  *agent_dbus_owner,
+                    const char                  *agent_username,
                     gboolean                     agent_has_modify,
-                    const char *                 setting_name,
+                    const char                  *setting_name,
                     NMSecretAgentGetSecretsFlags flags,
-                    GVariant *                   secrets,
-                    GError *                     error,
+                    GVariant                    *secrets,
+                    GError                      *error,
                     gpointer                     user_data)
 {
-    NMSettingsConnectionCallId * call_id = user_data;
-    NMSettingsConnection *       self;
-    NMSettingsConnectionPrivate *priv;
-    NMConnection *               applied_connection;
-    gs_free_error GError *local                    = NULL;
+    NMSettingsConnectionCallId   *call_id = user_data;
+    NMSettingsConnection         *self;
+    NMSettingsConnectionPrivate  *priv;
+    NMConnection                 *applied_connection;
+    gs_free_error GError         *local            = NULL;
     gs_unref_object NMConnection *new_connection   = NULL;
     gboolean                      agent_had_system = FALSE;
     ForEachSecretFlags cmp_flags = {NM_SETTING_SECRET_FLAG_NONE, NM_SETTING_SECRET_FLAG_NONE};
@@ -1068,21 +1068,21 @@ get_secrets_idle_cb(NMSettingsConnectionCallId *call_id)
  * Returns: a call ID which may be used to cancel the ongoing secrets request.
  **/
 NMSettingsConnectionCallId *
-nm_settings_connection_get_secrets(NMSettingsConnection *          self,
-                                   NMConnection *                  applied_connection,
-                                   NMAuthSubject *                 subject,
-                                   const char *                    setting_name,
+nm_settings_connection_get_secrets(NMSettingsConnection           *self,
+                                   NMConnection                   *applied_connection,
+                                   NMAuthSubject                  *subject,
+                                   const char                     *setting_name,
                                    NMSecretAgentGetSecretsFlags    flags,
-                                   const char *const *             hints,
+                                   const char *const              *hints,
                                    NMSettingsConnectionSecretsFunc callback,
                                    gpointer                        callback_data)
 {
     NMSettingsConnectionPrivate *priv = NM_SETTINGS_CONNECTION_GET_PRIVATE(self);
     NMAgentManagerCallId         call_id_a;
-    gs_free char *               joined_hints = NULL;
-    NMSettingsConnectionCallId * call_id;
-    GError *                     local        = NULL;
-    gs_unref_variant GVariant *system_secrets = NULL;
+    gs_free char                *joined_hints = NULL;
+    NMSettingsConnectionCallId  *call_id;
+    GError                      *local          = NULL;
+    gs_unref_variant GVariant   *system_secrets = NULL;
 
     g_return_val_if_fail(NM_IS_SETTINGS_CONNECTION(self), NULL);
     g_return_val_if_fail(
@@ -1168,12 +1168,12 @@ schedule_dummy:
 }
 
 static void
-_get_secrets_cancel(NMSettingsConnection *      self,
+_get_secrets_cancel(NMSettingsConnection       *self,
                     NMSettingsConnectionCallId *call_id,
                     gboolean                    is_disposing)
 {
-    NMSettingsConnectionPrivate *priv = NM_SETTINGS_CONNECTION_GET_PRIVATE(self);
-    gs_free_error GError *error       = NULL;
+    NMSettingsConnectionPrivate *priv  = NM_SETTINGS_CONNECTION_GET_PRIVATE(self);
+    gs_free_error GError        *error = NULL;
 
     nm_assert(c_list_contains(&priv->call_ids_lst_head, &call_id->call_ids_lst));
 
@@ -1192,7 +1192,7 @@ _get_secrets_cancel(NMSettingsConnection *      self,
 }
 
 void
-nm_settings_connection_cancel_secrets(NMSettingsConnection *      self,
+nm_settings_connection_cancel_secrets(NMSettingsConnection       *self,
                                       NMSettingsConnectionCallId *call_id)
 {
     _LOGD("(%p) secrets canceled", call_id);
@@ -1202,31 +1202,31 @@ nm_settings_connection_cancel_secrets(NMSettingsConnection *      self,
 
 /*****************************************************************************/
 
-typedef void (*AuthCallback)(NMSettingsConnection * self,
+typedef void (*AuthCallback)(NMSettingsConnection  *self,
                              GDBusMethodInvocation *context,
-                             NMAuthSubject *        subject,
-                             GError *               error,
+                             NMAuthSubject         *subject,
+                             GError                *error,
                              gpointer               data);
 
 typedef struct {
     CList                  auth_lst;
-    NMAuthManagerCallId *  call_id;
-    NMSettingsConnection * self;
+    NMAuthManagerCallId   *call_id;
+    NMSettingsConnection  *self;
     AuthCallback           callback;
     gpointer               callback_data;
     GDBusMethodInvocation *invocation;
-    NMAuthSubject *        subject;
+    NMAuthSubject         *subject;
 } AuthData;
 
 static void
-pk_auth_cb(NMAuthManager *      auth_manager,
+pk_auth_cb(NMAuthManager       *auth_manager,
            NMAuthManagerCallId *auth_call_id,
            gboolean             is_authorized,
            gboolean             is_challenge,
-           GError *             auth_error,
+           GError              *auth_error,
            gpointer             user_data)
 {
-    AuthData *            auth_data = user_data;
+    AuthData             *auth_data = user_data;
     NMSettingsConnection *self;
     gs_free_error GError *error = NULL;
 
@@ -1293,16 +1293,16 @@ _new_auth_subject(GDBusMethodInvocation *context, GError **error)
 
 /* may either invoke callback synchronously or asynchronously. */
 static void
-auth_start(NMSettingsConnection * self,
+auth_start(NMSettingsConnection  *self,
            GDBusMethodInvocation *invocation,
-           NMAuthSubject *        subject,
-           const char *           check_permission,
+           NMAuthSubject         *subject,
+           const char            *check_permission,
            AuthCallback           callback,
            gpointer               callback_data)
 {
     NMSettingsConnectionPrivate *priv = NM_SETTINGS_CONNECTION_GET_PRIVATE(self);
-    AuthData *                   auth_data;
-    GError *                     error = NULL;
+    AuthData                    *auth_data;
+    GError                      *error = NULL;
 
     nm_assert(nm_dbus_object_is_exported(NM_DBUS_OBJECT(self)));
     nm_assert(G_IS_DBUS_METHOD_INVOCATION(invocation));
@@ -1342,13 +1342,13 @@ auth_start(NMSettingsConnection * self,
 /**** DBus method handlers ************************************/
 
 static void
-get_settings_auth_cb(NMSettingsConnection * self,
+get_settings_auth_cb(NMSettingsConnection  *self,
                      GDBusMethodInvocation *context,
-                     NMAuthSubject *        subject,
-                     GError *               error,
+                     NMAuthSubject         *subject,
+                     GError                *error,
                      gpointer               data)
 {
-    const char *                     seen_bssids_strv[SEEN_BSSIDS_MAX + 1];
+    const char                      *seen_bssids_strv[SEEN_BSSIDS_MAX + 1];
     NMConnectionSerializationOptions options = {};
 
     if (error) {
@@ -1381,17 +1381,17 @@ get_settings_auth_cb(NMSettingsConnection * self,
 }
 
 static void
-impl_settings_connection_get_settings(NMDBusObject *                     obj,
+impl_settings_connection_get_settings(NMDBusObject                      *obj,
                                       const NMDBusInterfaceInfoExtended *interface_info,
-                                      const NMDBusMethodInfoExtended *   method_info,
-                                      GDBusConnection *                  connection,
-                                      const char *                       sender,
-                                      GDBusMethodInvocation *            invocation,
-                                      GVariant *                         parameters)
+                                      const NMDBusMethodInfoExtended    *method_info,
+                                      GDBusConnection                   *connection,
+                                      const char                        *sender,
+                                      GDBusMethodInvocation             *invocation,
+                                      GVariant                          *parameters)
 {
-    NMSettingsConnection *self             = NM_SETTINGS_CONNECTION(obj);
+    NMSettingsConnection          *self    = NM_SETTINGS_CONNECTION(obj);
     gs_unref_object NMAuthSubject *subject = NULL;
-    GError *                       error   = NULL;
+    GError                        *error   = NULL;
 
     subject = _new_auth_subject(invocation, &error);
     if (!subject) {
@@ -1404,11 +1404,11 @@ impl_settings_connection_get_settings(NMDBusObject *                     obj,
 
 typedef struct {
     GDBusMethodInvocation *context;
-    NMAgentManager *       agent_mgr;
-    NMAuthSubject *        subject;
-    NMConnection *         new_settings;
+    NMAgentManager        *agent_mgr;
+    NMAuthSubject         *subject;
+    NMConnection          *new_settings;
     NMSettingsUpdate2Flags flags;
-    char *                 audit_args;
+    char                  *audit_args;
     bool                   is_update2 : 1;
 } UpdateInfo;
 
@@ -1486,15 +1486,15 @@ _autoconnect_retries_set(NMSettingsConnection *self, int retries, gboolean is_re
 }
 
 static void
-update_auth_cb(NMSettingsConnection * self,
+update_auth_cb(NMSettingsConnection  *self,
                GDBusMethodInvocation *context,
-               NMAuthSubject *        subject,
-               GError *               error,
+               NMAuthSubject         *subject,
+               GError                *error,
                gpointer               data)
 {
-    NMSettingsConnectionPrivate *priv;
-    UpdateInfo *                 info     = data;
-    gs_free_error GError *          local = NULL;
+    NMSettingsConnectionPrivate    *priv;
+    UpdateInfo                     *info  = data;
+    gs_free_error GError           *local = NULL;
     NMSettingsConnectionPersistMode persist_mode;
 
     if (error) {
@@ -1638,18 +1638,18 @@ get_update_modify_permission(NMConnection *old, NMConnection *new)
 }
 
 static void
-settings_connection_update(NMSettingsConnection * self,
+settings_connection_update(NMSettingsConnection  *self,
                            gboolean               is_update2,
                            GDBusMethodInvocation *context,
-                           GVariant *             new_settings,
+                           GVariant              *new_settings,
                            NMSettingsUpdate2Flags flags)
 {
     NMSettingsConnectionPrivate *priv    = NM_SETTINGS_CONNECTION_GET_PRIVATE(self);
-    NMAuthSubject *              subject = NULL;
-    NMConnection *               tmp     = NULL;
-    GError *                     error   = NULL;
-    UpdateInfo *                 info;
-    const char *                 permission;
+    NMAuthSubject               *subject = NULL;
+    NMConnection                *tmp     = NULL;
+    GError                      *error   = NULL;
+    UpdateInfo                  *info;
+    const char                  *permission;
 
     /* Check if the settings are valid first */
     if (new_settings) {
@@ -1712,15 +1712,15 @@ error:
 }
 
 static void
-impl_settings_connection_update(NMDBusObject *                     obj,
+impl_settings_connection_update(NMDBusObject                      *obj,
                                 const NMDBusInterfaceInfoExtended *interface_info,
-                                const NMDBusMethodInfoExtended *   method_info,
-                                GDBusConnection *                  connection,
-                                const char *                       sender,
-                                GDBusMethodInvocation *            invocation,
-                                GVariant *                         parameters)
+                                const NMDBusMethodInfoExtended    *method_info,
+                                GDBusConnection                   *connection,
+                                const char                        *sender,
+                                GDBusMethodInvocation             *invocation,
+                                GVariant                          *parameters)
 {
-    NMSettingsConnection *self          = NM_SETTINGS_CONNECTION(obj);
+    NMSettingsConnection      *self     = NM_SETTINGS_CONNECTION(obj);
     gs_unref_variant GVariant *settings = NULL;
 
     g_variant_get(parameters, "(@a{sa{sv}})", &settings);
@@ -1728,15 +1728,15 @@ impl_settings_connection_update(NMDBusObject *                     obj,
 }
 
 static void
-impl_settings_connection_update_unsaved(NMDBusObject *                     obj,
+impl_settings_connection_update_unsaved(NMDBusObject                      *obj,
                                         const NMDBusInterfaceInfoExtended *interface_info,
-                                        const NMDBusMethodInfoExtended *   method_info,
-                                        GDBusConnection *                  connection,
-                                        const char *                       sender,
-                                        GDBusMethodInvocation *            invocation,
-                                        GVariant *                         parameters)
+                                        const NMDBusMethodInfoExtended    *method_info,
+                                        GDBusConnection                   *connection,
+                                        const char                        *sender,
+                                        GDBusMethodInvocation             *invocation,
+                                        GVariant                          *parameters)
 {
-    NMSettingsConnection *self          = NM_SETTINGS_CONNECTION(obj);
+    NMSettingsConnection      *self     = NM_SETTINGS_CONNECTION(obj);
     gs_unref_variant GVariant *settings = NULL;
 
     g_variant_get(parameters, "(@a{sa{sv}})", &settings);
@@ -1748,13 +1748,13 @@ impl_settings_connection_update_unsaved(NMDBusObject *                     obj,
 }
 
 static void
-impl_settings_connection_save(NMDBusObject *                     obj,
+impl_settings_connection_save(NMDBusObject                      *obj,
                               const NMDBusInterfaceInfoExtended *interface_info,
-                              const NMDBusMethodInfoExtended *   method_info,
-                              GDBusConnection *                  connection,
-                              const char *                       sender,
-                              GDBusMethodInvocation *            invocation,
-                              GVariant *                         parameters)
+                              const NMDBusMethodInfoExtended    *method_info,
+                              GDBusConnection                   *connection,
+                              const char                        *sender,
+                              GDBusMethodInvocation             *invocation,
+                              GVariant                          *parameters)
 {
     NMSettingsConnection *self = NM_SETTINGS_CONNECTION(obj);
 
@@ -1762,21 +1762,21 @@ impl_settings_connection_save(NMDBusObject *                     obj,
 }
 
 static void
-impl_settings_connection_update2(NMDBusObject *                     obj,
+impl_settings_connection_update2(NMDBusObject                      *obj,
                                  const NMDBusInterfaceInfoExtended *interface_info,
-                                 const NMDBusMethodInfoExtended *   method_info,
-                                 GDBusConnection *                  connection,
-                                 const char *                       sender,
-                                 GDBusMethodInvocation *            invocation,
-                                 GVariant *                         parameters)
+                                 const NMDBusMethodInfoExtended    *method_info,
+                                 GDBusConnection                   *connection,
+                                 const char                        *sender,
+                                 GDBusMethodInvocation             *invocation,
+                                 GVariant                          *parameters)
 {
-    NMSettingsConnection *self          = NM_SETTINGS_CONNECTION(obj);
+    NMSettingsConnection      *self     = NM_SETTINGS_CONNECTION(obj);
     gs_unref_variant GVariant *settings = NULL;
     gs_unref_variant GVariant *args     = NULL;
     guint32                    flags_u;
-    GError *                   error = NULL;
+    GError                    *error = NULL;
     GVariantIter               iter;
-    const char *               args_name;
+    const char                *args_name;
     NMSettingsUpdate2Flags     flags;
 
     g_variant_get(parameters, "(@a{sa{sv}}u@a{sv})", &settings, &flags_u, &args);
@@ -1825,10 +1825,10 @@ impl_settings_connection_update2(NMDBusObject *                     obj,
 }
 
 static void
-delete_auth_cb(NMSettingsConnection * self,
+delete_auth_cb(NMSettingsConnection  *self,
                GDBusMethodInvocation *context,
-               NMAuthSubject *        subject,
-               GError *               error,
+               NMAuthSubject         *subject,
+               GError                *error,
                gpointer               data)
 {
     gs_unref_object NMSettingsConnection *self_keep_alive = NULL;
@@ -1869,17 +1869,17 @@ get_modify_permission_basic(NMSettingsConnection *self)
 }
 
 static void
-impl_settings_connection_delete(NMDBusObject *                     obj,
+impl_settings_connection_delete(NMDBusObject                      *obj,
                                 const NMDBusInterfaceInfoExtended *interface_info,
-                                const NMDBusMethodInfoExtended *   method_info,
-                                GDBusConnection *                  connection,
-                                const char *                       sender,
-                                GDBusMethodInvocation *            invocation,
-                                GVariant *                         parameters)
+                                const NMDBusMethodInfoExtended    *method_info,
+                                GDBusConnection                   *connection,
+                                const char                        *sender,
+                                GDBusMethodInvocation             *invocation,
+                                GVariant                          *parameters)
 {
-    NMSettingsConnection *self             = NM_SETTINGS_CONNECTION(obj);
+    NMSettingsConnection          *self    = NM_SETTINGS_CONNECTION(obj);
     gs_unref_object NMAuthSubject *subject = NULL;
-    GError *                       error   = NULL;
+    GError                        *error   = NULL;
 
     nm_assert(nm_settings_connection_still_valid(self));
 
@@ -1897,15 +1897,15 @@ err:
 /*****************************************************************************/
 
 static void
-dbus_get_agent_secrets_cb(NMSettingsConnection *      self,
+dbus_get_agent_secrets_cb(NMSettingsConnection       *self,
                           NMSettingsConnectionCallId *call_id,
-                          const char *                agent_username,
-                          const char *                setting_name,
-                          GError *                    error,
+                          const char                 *agent_username,
+                          const char                 *setting_name,
+                          GError                     *error,
                           gpointer                    user_data)
 {
     GDBusMethodInvocation *context = user_data;
-    GVariant *             dict;
+    GVariant              *dict;
 
     if (error)
         g_dbus_method_invocation_return_gerror(context, error);
@@ -1924,10 +1924,10 @@ dbus_get_agent_secrets_cb(NMSettingsConnection *      self,
 }
 
 static void
-dbus_get_secrets_auth_cb(NMSettingsConnection * self,
+dbus_get_secrets_auth_cb(NMSettingsConnection  *self,
                          GDBusMethodInvocation *context,
-                         NMAuthSubject *        subject,
-                         GError *               error,
+                         NMAuthSubject         *subject,
+                         GError                *error,
                          gpointer               user_data)
 {
     char *setting_name = user_data;
@@ -1951,18 +1951,18 @@ dbus_get_secrets_auth_cb(NMSettingsConnection * self,
 }
 
 static void
-impl_settings_connection_get_secrets(NMDBusObject *                     obj,
+impl_settings_connection_get_secrets(NMDBusObject                      *obj,
                                      const NMDBusInterfaceInfoExtended *interface_info,
-                                     const NMDBusMethodInfoExtended *   method_info,
-                                     GDBusConnection *                  connection,
-                                     const char *                       sender,
-                                     GDBusMethodInvocation *            invocation,
-                                     GVariant *                         parameters)
+                                     const NMDBusMethodInfoExtended    *method_info,
+                                     GDBusConnection                   *connection,
+                                     const char                        *sender,
+                                     GDBusMethodInvocation             *invocation,
+                                     GVariant                          *parameters)
 {
-    NMSettingsConnection *self             = NM_SETTINGS_CONNECTION(obj);
+    NMSettingsConnection          *self    = NM_SETTINGS_CONNECTION(obj);
     gs_unref_object NMAuthSubject *subject = NULL;
-    GError *                       error   = NULL;
-    const char *                   setting_name;
+    GError                        *error   = NULL;
+    const char                    *setting_name;
 
     subject = _new_auth_subject(invocation, &error);
     if (!subject) {
@@ -1981,14 +1981,14 @@ impl_settings_connection_get_secrets(NMDBusObject *                     obj,
 }
 
 static void
-dbus_clear_secrets_auth_cb(NMSettingsConnection * self,
+dbus_clear_secrets_auth_cb(NMSettingsConnection  *self,
                            GDBusMethodInvocation *context,
-                           NMAuthSubject *        subject,
-                           GError *               error,
+                           NMAuthSubject         *subject,
+                           GError                *error,
                            gpointer               user_data)
 {
-    NMSettingsConnectionPrivate *priv               = NM_SETTINGS_CONNECTION_GET_PRIVATE(self);
-    gs_free_error GError *local                     = NULL;
+    NMSettingsConnectionPrivate  *priv              = NM_SETTINGS_CONNECTION_GET_PRIVATE(self);
+    gs_free_error GError         *local             = NULL;
     gs_unref_object NMConnection *connection_cloned = NULL;
 
     if (error) {
@@ -2040,17 +2040,17 @@ dbus_clear_secrets_auth_cb(NMSettingsConnection * self,
 }
 
 static void
-impl_settings_connection_clear_secrets(NMDBusObject *                     obj,
+impl_settings_connection_clear_secrets(NMDBusObject                      *obj,
                                        const NMDBusInterfaceInfoExtended *interface_info,
-                                       const NMDBusMethodInfoExtended *   method_info,
-                                       GDBusConnection *                  connection,
-                                       const char *                       sender,
-                                       GDBusMethodInvocation *            invocation,
-                                       GVariant *                         parameters)
+                                       const NMDBusMethodInfoExtended    *method_info,
+                                       GDBusConnection                   *connection,
+                                       const char                        *sender,
+                                       GDBusMethodInvocation             *invocation,
+                                       GVariant                          *parameters)
 {
-    NMSettingsConnection *self             = NM_SETTINGS_CONNECTION(obj);
+    NMSettingsConnection          *self    = NM_SETTINGS_CONNECTION(obj);
     gs_unref_object NMAuthSubject *subject = NULL;
-    GError *                       error   = NULL;
+    GError                        *error   = NULL;
 
     subject = _new_auth_subject(invocation, &error);
     if (!subject) {
@@ -2092,7 +2092,7 @@ _nm_settings_connection_emit_dbus_signal_removed(NMSettingsConnection *self)
 }
 
 void
-_nm_settings_connection_emit_signal_updated_internal(NMSettingsConnection *           self,
+_nm_settings_connection_emit_signal_updated_internal(NMSettingsConnection            *self,
                                                      NMSettingsConnectionUpdateReason update_reason)
 {
     g_signal_emit(self, signals[UPDATED_INTERNAL], 0, (guint) update_reason);
@@ -2119,7 +2119,7 @@ nm_settings_connection_get_flags(NMSettingsConnection *self)
 }
 
 NMSettingsConnectionIntFlags
-nm_settings_connection_set_flags_full(NMSettingsConnection *       self,
+nm_settings_connection_set_flags_full(NMSettingsConnection        *self,
                                       NMSettingsConnectionIntFlags mask,
                                       NMSettingsConnectionIntFlags value)
 {
@@ -2285,7 +2285,7 @@ void
 nm_settings_connection_update_timestamp(NMSettingsConnection *self, guint64 timestamp)
 {
     NMSettingsConnectionPrivate *priv;
-    const char *                 connection_uuid;
+    const char                  *connection_uuid;
     char                         sbuf[60];
 
     g_return_if_fail(NM_IS_SETTINGS_CONNECTION(self));
@@ -2315,11 +2315,11 @@ nm_settings_connection_update_timestamp(NMSettingsConnection *self, guint64 time
 
 void
 _nm_settings_connection_register_kf_dbs(NMSettingsConnection *self,
-                                        NMKeyFileDB *         kf_db_timestamps,
-                                        NMKeyFileDB *         kf_db_seen_bssids)
+                                        NMKeyFileDB          *kf_db_timestamps,
+                                        NMKeyFileDB          *kf_db_seen_bssids)
 {
     NMSettingsConnectionPrivate *priv;
-    const char *                 connection_uuid;
+    const char                  *connection_uuid;
 
     g_return_if_fail(NM_IS_SETTINGS_CONNECTION(self));
     g_return_if_fail(kf_db_timestamps);
@@ -2402,7 +2402,7 @@ static guint
 _get_seen_bssids(NMSettingsConnection *self, const char *strv_buf[static(SEEN_BSSIDS_MAX + 1)])
 {
     NMSettingsConnectionPrivate *priv = NM_SETTINGS_CONNECTION_GET_PRIVATE(self);
-    SeenBssidEntry *             entry;
+    SeenBssidEntry              *entry;
     guint                        i;
 
     i = 0;
@@ -2450,11 +2450,11 @@ void
 nm_settings_connection_add_seen_bssid(NMSettingsConnection *self, const char *seen_bssid)
 {
     NMSettingsConnectionPrivate *priv = NM_SETTINGS_CONNECTION_GET_PRIVATE(self);
-    const char *                 seen_bssids_strv[SEEN_BSSIDS_MAX + 1];
+    const char                  *seen_bssids_strv[SEEN_BSSIDS_MAX + 1];
     NMEtherAddr                  addr_bin;
-    const char *                 connection_uuid;
+    const char                  *connection_uuid;
     SeenBssidEntry               entry_stack;
-    SeenBssidEntry *             entry;
+    SeenBssidEntry              *entry;
     guint                        i;
 
     g_return_if_fail(seen_bssid);
@@ -2562,12 +2562,12 @@ nm_settings_connection_autoconnect_blocked_reason_get(NMSettingsConnection *self
 }
 
 gboolean
-nm_settings_connection_autoconnect_blocked_reason_set_full(NMSettingsConnection *             self,
+nm_settings_connection_autoconnect_blocked_reason_set_full(NMSettingsConnection              *self,
                                                            NMSettingsAutoconnectBlockedReason mask,
                                                            NMSettingsAutoconnectBlockedReason value)
 {
     NMSettingsAutoconnectBlockedReason v;
-    NMSettingsConnectionPrivate *      priv = NM_SETTINGS_CONNECTION_GET_PRIVATE(self);
+    NMSettingsConnectionPrivate       *priv = NM_SETTINGS_CONNECTION_GET_PRIVATE(self);
     char                               buf[100];
 
     nm_assert(mask);
@@ -2641,7 +2641,7 @@ const char *
 nm_settings_connection_get_uuid(NMSettingsConnection *self)
 {
     NMSettingsConnectionPrivate *priv;
-    const char *                 uuid;
+    const char                  *uuid;
 
     g_return_val_if_fail(NM_IS_SETTINGS_CONNECTION(self), NULL);
 
@@ -2668,7 +2668,7 @@ void
 _nm_settings_connection_cleanup_after_remove(NMSettingsConnection *self)
 {
     NMSettingsConnectionPrivate *priv = NM_SETTINGS_CONNECTION_GET_PRIVATE(self);
-    AuthData *                   auth_data;
+    AuthData                    *auth_data;
 
     while ((auth_data = c_list_first_entry(&priv->auth_lst_head, AuthData, auth_lst)))
         nm_auth_manager_check_authorization_cancel(auth_data->call_id);
@@ -2730,9 +2730,9 @@ nm_settings_connection_new(void)
 static void
 dispose(GObject *object)
 {
-    NMSettingsConnection *       self = NM_SETTINGS_CONNECTION(object);
+    NMSettingsConnection        *self = NM_SETTINGS_CONNECTION(object);
     NMSettingsConnectionPrivate *priv = NM_SETTINGS_CONNECTION_GET_PRIVATE(self);
-    NMSettingsConnectionCallId * call_id, *call_id_safe;
+    NMSettingsConnectionCallId  *call_id, *call_id_safe;
 
     _LOGD("disposing");
 
@@ -2837,7 +2837,7 @@ static const NMDBusInterfaceInfoExtended interface_info_settings_connection = {
 static void
 nm_settings_connection_class_init(NMSettingsConnectionClass *klass)
 {
-    GObjectClass *     object_class      = G_OBJECT_CLASS(klass);
+    GObjectClass      *object_class      = G_OBJECT_CLASS(klass);
     NMDBusObjectClass *dbus_object_class = NM_DBUS_OBJECT_CLASS(klass);
 
     g_type_class_add_private(klass, sizeof(NMSettingsConnectionPrivate));