diff options
| author | Lars Hjemli <hjemli@gmail.com> | 2009-08-17 09:19:05 +0200 |
|---|---|---|
| committer | Lars Hjemli <hjemli@gmail.com> | 2009-08-17 09:24:36 +0200 |
| commit | 8a631b1173b1abecc5a737b0e21751ddbabf9df2 (patch) | |
| tree | 93320a0e21c1f13e936ccac66d250b28fa87acc1 | |
| parent | fdd559abd6e6ec5e522dc5496b2bcabd36d6ba9d (diff) | |
ui-tag.c: do not segfault when id is missing from query-string
The purpose of the tag page is to print info about a specific tag, but if no tag was specified on the query-string cgit used to segfault. With this patch, cgit will fallback to the value of the 'h' parameter instead (which is never NULL due to prepare_repo_cmd() in cgit.c). It will now also verify that the specified tagname is in fact a valid ref in the 'refs/tags/' namespace, i.e. specifying 'id=master' will trigger a 'Bad tag reference' error. Noticed-by: Eric Wong <normalperson@yhbt.net> Signed-off-by: Lars Hjemli <hjemli@gmail.com>
| -rw-r--r-- | ui-tag.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/ui-tag.c b/ui-tag.c index 0e056e0..8c263ab 100644 --- a/ui-tag.c +++ b/ui-tag.c @@ -37,7 +37,10 @@ void cgit_print_tag(char *revname) struct tag *tag; struct taginfo *info; - if (get_sha1(revname, sha1)) { + if (!revname) + revname = ctx.qry.head; + + if (get_sha1(fmt("refs/tags/%s", revname), sha1)) { cgit_print_error(fmt("Bad tag reference: %s", revname)); return; } |