New upstream version 1.12.4 upstream/1.12.4

1 files changed, 1 insertions, 15 deletions

diff --git a/shared/nm-utils/nm-hash-utils.h b/shared/nm-utils/nm-hash-utils.h
index b797fb75..b7742e0f 100644
--- a/shared/nm-utils/nm-hash-utils.h
+++ b/shared/nm-utils/nm-hash-utils.h
@@ -57,11 +57,6 @@ nm_hash_update (NMHashState *state, const void *ptr, gsize n)
 	nm_assert (ptr);
 	nm_assert (n > 0);
 
-	/* Note: the data passed in here might be sensitive data (secrets),
-	 * that we should nm_explicty_zero() afterwards. However, since
-	 * we are using siphash24 with a random key, that is not really
-	 * necessary. Something to keep in mind, if we ever move away from
-	 * this hash implementation. */
 	c_siphash_append (&state->_state, ptr, n);
 }
 
@@ -173,7 +168,7 @@ nm_hash_update_mem (NMHashState *state, const void *ptr, gsize n)
 	 * instead. */
 	nm_hash_update (state, &n, sizeof (n));
 	if (n > 0)
-		nm_hash_update (state, ptr, n);
+		c_siphash_append (&state->_state, ptr, n);
 }
 
 static inline void
@@ -214,15 +209,6 @@ guint nm_direct_hash (gconstpointer str);
 guint nm_hash_str (const char *str);
 guint nm_str_hash (gconstpointer str);
 
-#define nm_hash_val(static_seed, val) \
-	({ \
-		NMHashState _h; \
-		\
-		nm_hash_init (&_h, static_seed); \
-		nm_hash_update_val (&_h, val); \
-		nm_hash_complete (&_h); \
-	})
-
 /*****************************************************************************/
 
 /* nm_pstr_*() are for hashing keys that are pointers to strings,