From e5ca46bf4b974ce3b51d09da4c7ad741aaa70ede Mon Sep 17 00:00:00 2001 From: Lars Hjemli Date: Sun, 24 Feb 2008 15:35:52 +0100 Subject: Brown paper bag: don't use `grep -v` For some inexplicable reason I'd gotten the semantics of `grep -v` totally backwards, thinking it somehow would make the exitcode from grep indicate the non-match of the specified pattern. This fixes the broken tests and gives me a valuable lession about shell programming at the same time. Signed-off-by: Lars Hjemli --- tests/t0101-index.sh | 4 ++-- tests/t0102-summary.sh | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) (limited to 'tests') diff --git a/tests/t0101-index.sh b/tests/t0101-index.sh index 59edc59..445af6a 100755 --- a/tests/t0101-index.sh +++ b/tests/t0101-index.sh @@ -9,7 +9,7 @@ run_test 'find foo repo' 'grep -e "foo" trash/tmp' run_test 'find foo description' 'grep -e "\[no description\]" trash/tmp' run_test 'find bar repo' 'grep -e "bar" trash/tmp' run_test 'find bar description' 'grep -e "the bar repo" trash/tmp' -run_test 'no tree-link' 'grep -ve "foo/tree" trash/tmp' -run_test 'no log-link' 'grep -ve "foo/log" trash/tmp' +run_test 'no tree-link' '! grep -e "foo/tree" trash/tmp' +run_test 'no log-link' '! grep -e "foo/log" trash/tmp' tests_done diff --git a/tests/t0102-summary.sh b/tests/t0102-summary.sh index 7edd675..f0b0d9a 100755 --- a/tests/t0102-summary.sh +++ b/tests/t0102-summary.sh @@ -8,13 +8,13 @@ run_test 'generate foo summary' 'cgit_url "foo" >trash/tmp' run_test 'find commit 1' 'grep -e "commit 1" trash/tmp' run_test 'find commit 5' 'grep -e "commit 5" trash/tmp' run_test 'find branch master' 'grep -e "master" trash/tmp' -run_test 'no tags' 'grep -ve "tags" trash/tmp' +run_test 'no tags' '! grep -e "tags" trash/tmp' run_test 'generate bar summary' 'cgit_url "bar" >trash/tmp' -run_test 'no commit 45' 'grep -ve "commit 45" trash/tmp' +run_test 'no commit 45' '! grep -e "commit 45" trash/tmp' run_test 'find commit 46' 'grep -e "commit 46" trash/tmp' run_test 'find commit 50' 'grep -e "commit 50" trash/tmp' run_test 'find branch master' 'grep -e "master" trash/tmp' -run_test 'no tags' 'grep -ve "tags" trash/tmp' +run_test 'no tags' '! grep -e "tags" trash/tmp' tests_done -- cgit 1.3.0-6-gf8a5